Bug Summary

File:librecad/src/lib/engine/document/selection/lc_selectedset.cpp
Warning:line 48, column 21
Value stored to 'e' during its initialization is never read

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple x86_64-pc-linux-gnu -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name lc_selectedset.cpp -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=cplusplus -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 2 -fhalf-no-semantic-interposition -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fdebug-compilation-dir=/home/runner/work/LibreCAD/LibreCAD/librecad/src -fcoverage-compilation-dir=/home/runner/work/LibreCAD/LibreCAD/librecad/src -resource-dir /usr/lib/llvm-18/lib/clang/18 -D _REENTRANT -D DWGSUPPORT -D MUPARSER_STATIC -D QC_APPDIR="librecad" -D LC_VERSION=2.2.2_alpha1-607-g330d41cec -D LC_PRERELEASE=true; -D QT_NO_DEBUG -D QT_SVG_LIB -D QT_PRINTSUPPORT_LIB -D QT_WIDGETS_LIB -D QT_GUI_LIB -D QT_NETWORK_LIB -D QT_CORE_LIB -I . -I /usr/include -I ../../libraries/lciconengine -I ../../libraries/libdxfrw/src -I ../../libraries/jwwlib/src -I ../../libraries/shapelib/src -I cmd -I lib/actions -I lib/actions/visual_snap -I lib/actions/options -I lib/creation -I lib/debug -I lib/engine -I lib/engine/document -I lib/engine/document/blocks -I lib/engine/document/container -I lib/engine/document/dimstyles -I lib/engine/document/entities -I lib/engine/document/entities/support -I lib/engine/document/fonts -I lib/engine/document/io -I lib/engine/document/layers -I lib/engine/document/patterns -I lib/engine/document/selection -I lib/engine/document/textstyles -I lib/engine/document/ucs -I lib/engine/document/variables -I lib/engine/document/views -I lib/engine/clipboard -I lib/engine/overlays -I lib/engine/overlays/angles_base -I lib/engine/overlays/highlight -I lib/engine/overlays/preview -I lib/engine/overlays/references -I lib/engine/overlays/crosshair -I lib/engine/overlays/info_cursor -I lib/engine/overlays/overlay_box -I lib/engine/overlays/ucs_mark -I lib/engine/undo -I lib/engine/utils -I lib/engine/settings -I lib/fileio -I lib/filters -I lib/generators -I lib/generators/makercamsvg -I lib/generators/layers -I lib/generators/image -I lib/gui -I lib/gui/grid -I lib/gui/render -I lib/gui/render/headless -I lib/gui/render/widget -I lib/information -I lib/math -I lib/modification -I lib/selection -I lib/selection/metaentity -I lib/selection/metaentity/entities -I lib/printing -I lib/properties -I actions -I actions/dock_widgets -I actions/dock_widgets/block -I actions/dock_widgets/entity_info -I actions/dock_widgets/layer -I actions/dock_widgets/library -I actions/dock_widgets/ucs_list -I actions/drawing -I actions/drawing/draw -I actions/drawing/draw/arc -I actions/drawing/draw/circle -I actions/drawing/draw/curve -I actions/drawing/draw/spline -I actions/drawing/draw/dimensions -I actions/drawing/draw/ellipse -I actions/drawing/draw/hatch -I actions/drawing/draw/image -I actions/drawing/draw/line -I actions/drawing/draw/point -I actions/drawing/draw/rect -I actions/drawing/draw/polygon -I actions/drawing/draw/misc -I actions/drawing/draw/line/shapes -I actions/drawing/draw/line/misc -I actions/drawing/draw/line/shapes/rect -I actions/drawing/draw/line/shapes/polygon -I actions/drawing/draw/polyline -I actions/drawing/draw/text -I actions/drawing/edit -I actions/drawing/info -I actions/drawing/pick -I actions/drawing/modify -I actions/drawing/pen -I actions/drawing/rel_zero -I actions/drawing/selection -I actions/drawing/snap -I actions/drawing/zoom -I actions/file -I actions/options -I actions/print_preview -I ui -I ui/action_options -I ui/action_options/circle -I ui/action_options/curve -I ui/action_options/spline -I ui/action_options/dimensions -I ui/action_options/edit -I ui/action_options/image -I ui/action_options/info -I ui/action_options/insert -I ui/action_options/line -I ui/action_options/rect -I ui/action_options/polygon -I ui/action_options/misc -I ui/action_options/modify -I ui/action_options/ellipse -I ui/action_options/other -I ui/action_options/polyline -I ui/action_options/point -I ui/action_options/print_preview -I ui/action_options/selection -I ui/action_options/snap -I ui/action_options/text -I ui/actions -I ui/components -I ui/components/relative_position_assistant -I ui/components/comboboxes -I ui/components/containers -I ui/components/creators -I ui/components/layouts -I ui/components/pen -I ui/components/status_bar -I ui/components/toolbars -I ui/components/utils -I ui/dialogs -I ui/dialogs/actions -I ui/dialogs/actions/modify -I ui/dialogs/actions/quick_selection -I ui/dialogs/modify -I ui/dialogs/entity -I ui/dialogs/creators -I ui/dialogs/file -I ui/dialogs/file/export -I ui/dialogs/file/export/layers -I ui/dialogs/file/export/image -I ui/dialogs/file/export/makercam -I ui/dialogs/main -I ui/dialogs/settings -I ui/dialogs/settings/dimstyles -I ui/dialogs/settings/dimstyles/dimstyle_manager -I ui/dialogs/settings/dimstyles/dimstyle_manager/support -I ui/dialogs/settings/options_device -I ui/dialogs/settings/options_drawing -I ui/dialogs/settings/options_general -I ui/dialogs/settings/options_widget -I ui/dialogs/settings/shortcuts -I ui/dock_widgets -I ui/dock_widgets/block_widget -I ui/dock_widgets/command_line -I ui/dock_widgets/entity_info -I ui/dock_widgets/layer_widget -I ui/dock_widgets/layers_tree -I ui/dock_widgets/library_widget -I ui/dock_widgets/pen_palette -I ui/dock_widgets/pen_wizard -I ui/dock_widgets/property_sheet -I ui/dock_widgets/property_sheet/lib -I ui/dock_widgets/property_sheet/lib/properties -I ui/dock_widgets/property_sheet/lib/view -I ui/dock_widgets/property_sheet/lib/view/edit -I ui/dock_widgets/property_sheet/lib/widgets -I ui/dock_widgets/property_sheet/lib/widgets/sheet -I ui/dock_widgets/property_sheet/metaentity -I ui/dock_widgets/property_sheet/metaentity/entities -I ui/dock_widgets/property_sheet/metaentity/entities/document -I ui/dock_widgets/property_sheet/properties -I ui/dock_widgets/property_sheet/properties/action -I ui/dock_widgets/property_sheet/properties/bool -I ui/dock_widgets/property_sheet/properties/color -I ui/dock_widgets/property_sheet/properties/double -I ui/dock_widgets/property_sheet/properties/enum -I ui/dock_widgets/property_sheet/properties/int -I ui/dock_widgets/property_sheet/properties/layer -I ui/dock_widgets/property_sheet/properties/linetype -I ui/dock_widgets/property_sheet/properties/linewidth -I ui/dock_widgets/property_sheet/properties/rect -I ui/dock_widgets/property_sheet/properties/rsvector -I ui/dock_widgets/property_sheet/properties/string -I ui/dock_widgets/views_list -I ui/dock_widgets/ucs_list -I ui/dock_widgets/workspaces -I ui/dock_widgets/cad -I ui/main -I ui/main/init -I ui/main/persistence -I ui/main/release_check -I ui/main/support -I ui/main/fontviewer -I ui/main/workspaces -I ui/view -I main -I main/console_dxf2pdf -I test -I plugins -I ../res -I ../res/arrows -I ../res/controls -I ../res/dxf -I ../res/gdt -I ../res/icons -I ../res/images -I ../../../Qt/6.9.0/gcc_64/include -I ../../../Qt/6.9.0/gcc_64/include/QtSvg -I ../../../Qt/6.9.0/gcc_64/include/QtPrintSupport -I ../../../Qt/6.9.0/gcc_64/include/QtWidgets -I ../../../Qt/6.9.0/gcc_64/include/QtGui -I ../../../Qt/6.9.0/gcc_64/include/QtNetwork -I ../../../Qt/6.9.0/gcc_64/include/QtCore -I ../../generated/librecad/moc -I ../../generated/librecad/ui -I ../../../Qt/6.9.0/gcc_64/mkspecs/linux-g++ -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14 -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/x86_64-linux-gnu/c++/14 -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/backward -internal-isystem /usr/lib/llvm-18/lib/clang/18/include -internal-isystem /usr/local/include -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O2 -std=gnu++1z -fdeprecated-macro -ferror-limit 19 -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -vectorize-loops -vectorize-slp -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/runner/work/LibreCAD/LibreCAD/out/2026-08-04-154929-5069-1 -x c++ lib/engine/document/selection/lc_selectedset.cpp
1/*
2 * ********************************************************************************
3 * This file is part of the LibreCAD project, a 2D CAD program
4 *
5 * Copyright (C) 2025 LibreCAD.org
6 * Copyright (C) 2025 sand1024
7 *
8 * This program is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU General Public License
10 * as published by the Free Software Foundation; either version 2
11 * of the License, or (at your option) any later version.
12 *
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
21 * ********************************************************************************
22 */
23
24#include "lc_selectedset.h"
25
26#include "rs_entity.h"
27#include "rs_layer.h"
28
29LC_SelectedSet::LC_SelectedSet() = default;
30
31LC_SelectedSet::~LC_SelectedSet() {
32 m_entitiesList.clear();
33 m_listeners.clear();
34}
35
36void LC_SelectedSet::clear() {
37 for (const auto e: std::as_const(m_entitiesList)) {
38 e->setSelectionFlag(false);
39 }
40 m_entitiesList.clear();
41 fireSelectionChanged();
42}
43
44#define DEBUG_UNIQUE_SELECTION
45
46void LC_SelectedSet::add(RS_Entity* entity) {
47#ifdef DEBUG_UNIQUE_SELECTION
48 for (const auto e : std::as_const(m_entitiesList)) {
Value stored to 'e' during its initialization is never read
49 Q_ASSERT_X(e != entity, "LC_SelectedSet::add()", "Entity not unique in selection")static_cast<void>(false && (e != entity));
50 }
51#endif
52 m_entitiesList.push_back(entity);
53 fireSelectionChanged();
54}
55
56void LC_SelectedSet::remove(RS_Entity* entity) {
57 entity->setSelectionFlag(false);
58 m_entitiesList.removeOne(entity);
59 fireSelectionChanged();
60}
61
62void LC_SelectedSet::replaceBy(QList<RS_Entity*>& entities) {
63 for (const auto e: std::as_const(m_entitiesList)) {
64 e->setSelectionFlag(false);
65 }
66 m_entitiesList.clear();
67 m_entitiesList.append(entities);
68 // need to update flag again, as the same entity might be in current selection list (so it will be un-selected) and
69 // be added in new list (so it should be selected).
70 for (const auto e: std::as_const(entities)) {
71 e->setSelectionFlag(true);
72 }
73 fireSelectionChanged();
74}
75
76void LC_SelectedSet::addListener(LC_SelectedSetListener* listener) {
77 if (listener == nullptr) {
78 return;
79 }
80 for (const auto l : std::as_const(m_listeners)) {
81 if (l == listener) {
82 return;
83 }
84 }
85 m_listeners.append(listener);
86}
87
88void LC_SelectedSet::removeListener(LC_SelectedSetListener* listener) {
89 m_listeners.removeOne(listener);
90}
91
92void LC_SelectedSet::fireSelectionChanged() {
93 if (m_silentMode == 0) {
94 for (const auto l : std::as_const(m_listeners)) {
95 l->selectionChanged();
96 }
97 }
98 else{
99 m_changedInSilent = true;
100 }
101}
102
103void LC_SelectedSet::cleanup() {
104 if (m_entitiesList.empty()) {
105 return;
106 }
107 QList<RS_Entity*> validEntities;
108 for (const auto e: std::as_const(m_entitiesList)) {
109 bool valid = false;
110 if (e->isSet(RS2::FlagSelected) && e->isAlive()) {
111 const RS_Layer* layer = e->getLayerResolved();
112 if (!layer->isLocked() && !layer->isFrozen()) { // also clear selection for locked and freezed layers
113 valid = true;
114 }
115 }
116 if (valid) {
117 validEntities.append(e);
118 }
119 else {
120 e->setSelectionFlag(false);
121 }
122 }
123 const auto validEntitiesCount = validEntities.count();
124 const auto currentEntitiesCount = m_entitiesList.count();
125 if (validEntitiesCount != currentEntitiesCount) {
126 m_entitiesList.clear();
127 m_entitiesList.append(validEntities);
128 fireSelectionChanged();
129 }
130}
131
132bool LC_SelectedSet::collectSelectedEntities(QList<RS_Entity*>& list) {
133 bool cleanupNeeded = false;
134 for (const auto e: std::as_const(m_entitiesList)) {
135 if (e != nullptr) {
136 if (e->isSet(RS2::FlagSelected) && e->isNotSet(RS2::FlagDeleted)) {
137 list.append(e);
138 }
139 else {
140 cleanupNeeded = true;
141 }
142 }
143 }
144 if (cleanupNeeded) {
145 cleanup();
146 }
147 return !list.isEmpty();
148}
149
150bool LC_SelectedSet::collectSelectedEntities(QList<RS_Entity*>& list, const QList<RS2::EntityType>&types) {
151 const bool specificTypesNeeded = !types.empty();
152 bool cleanupNeeded = false;
153 for (const auto e: std::as_const(m_entitiesList)) {
154 if (e != nullptr) {
155 if (e->isSet(RS2::FlagSelected) && e->isNotSet(RS2::FlagDeleted)) {
156 if (specificTypesNeeded) {
157 RS2::EntityType type = e->rtti();
158 if (types.count(type) > 0) {
159 list.append(e);
160 }
161 }
162 else {
163 list.append(e);
164 }
165 }
166 else {
167 cleanupNeeded = true;
168 }
169 }
170 }
171 if (cleanupNeeded) {
172 cleanup();
173 }
174 return !list.isEmpty();
175}
176
177bool LC_SelectedSet::hasSelection() {
178 bool cleanupNeeded = false;
179 bool hasSelection = false;
180 for (const auto e: std::as_const(m_entitiesList)) {
181 if (e != nullptr) {
182 if (e->isSet(RS2::FlagSelected) && e->isNotSet(RS2::FlagDeleted)) {
183 hasSelection = true;
184 break;
185 }
186 cleanupNeeded = true;
187 }
188 }
189 if (cleanupNeeded) {
190 cleanup();
191 }
192 return hasSelection;
193}
194
195void LC_SelectedSet::disableListeners() {
196 m_silentMode++;
197}
198
199bool LC_SelectedSet::enableListeners() {
200 m_silentMode --;
201 if (m_silentMode == 0) {
202 if (m_changedInSilent) {
203 m_changedInSilent = false; // fixme - review what to return!
204 fireSelectionChanged();
205 return true;
206 }
207 return false;
208 }
209 return false;
210}