Bug Summary

File:librecad/src/ui/dialogs/file/export/layers/lc_exportlayersdialogservice.cpp
Warning:line 199, column 16
Potential leak of memory pointed to by 'exportOptionsWidget'

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple x86_64-pc-linux-gnu -O2 -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name lc_exportlayersdialogservice.cpp -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=cplusplus -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 2 -fhalf-no-semantic-interposition -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fdebug-compilation-dir=/home/runner/work/LibreCAD/LibreCAD/librecad/src -fcoverage-compilation-dir=/home/runner/work/LibreCAD/LibreCAD/librecad/src -resource-dir /usr/lib/llvm-21/lib/clang/21 -D _REENTRANT -D DWGSUPPORT -D MUPARSER_STATIC -D LC_WITH_OPENTYPE=0 -D QC_APPDIR=librecad -D LC_VERSION=2.2.2_alpha1-853-ge2a8c2931 -D LC_PRERELEASE=true; -D QT_NO_DEBUG -D QT_SVG_LIB -D QT_PRINTSUPPORT_LIB -D QT_WIDGETS_LIB -D QT_GUI_LIB -D QT_NETWORK_LIB -D QT_CORE_LIB -I . -I /usr/include -I ../../libraries/lciconengine -I ../../libraries/libdxfrw/src -I ../../libraries/libdxfrw/src/intern -I ../../libraries/jwwlib/src -I ../../libraries/shapelib/src -I ../../libraries/qtbidi -I cmd -I lib/actions -I lib/actions/visual_snap -I lib/actions/options -I lib/creation -I lib/debug -I lib/engine -I lib/engine/document -I lib/engine/document/blocks -I lib/engine/document/container -I lib/engine/document/dimstyles -I lib/engine/document/entities -I lib/engine/document/entities/support -I lib/engine/document/fonts -I lib/engine/document/io -I lib/engine/document/layers -I lib/engine/document/linetypes -I lib/engine/document/patterns -I lib/engine/document/selection -I lib/engine/document/textstyles -I lib/engine/document/ucs -I lib/engine/document/variables -I lib/engine/document/views -I lib/engine/clipboard -I lib/engine/overlays -I lib/engine/overlays/angles_base -I lib/engine/overlays/highlight -I lib/engine/overlays/preview -I lib/engine/overlays/references -I lib/engine/overlays/crosshair -I lib/engine/overlays/info_cursor -I lib/engine/overlays/overlay_box -I lib/engine/overlays/ucs_mark -I lib/engine/undo -I lib/engine/utils -I lib/engine/settings -I lib/fileio -I lib/filters -I lib/generators -I lib/generators/makercamsvg -I lib/generators/layers -I lib/generators/image -I lib/gui -I lib/gui/grid -I lib/gui/render -I lib/gui/render/headless -I lib/gui/render/widget -I lib/information -I lib/math -I lib/modification -I lib/selection -I lib/selection/metaentity -I lib/selection/metaentity/entities -I lib/printing -I lib/properties -I actions -I actions/dock_widgets -I actions/dock_widgets/block -I actions/dock_widgets/entity_info -I actions/dock_widgets/layer -I actions/dock_widgets/library -I actions/dock_widgets/ucs_list -I actions/drawing -I actions/drawing/draw -I actions/drawing/draw/arc -I actions/drawing/draw/circle -I actions/drawing/draw/curve -I actions/drawing/draw/spline -I actions/drawing/draw/dimensions -I actions/drawing/draw/ellipse -I actions/drawing/draw/hatch -I actions/drawing/draw/image -I actions/drawing/draw/line -I actions/drawing/draw/point -I actions/drawing/draw/rect -I actions/drawing/draw/polygon -I actions/drawing/draw/misc -I actions/drawing/draw/line/shapes -I actions/drawing/draw/line/misc -I actions/drawing/draw/line/shapes/rect -I actions/drawing/draw/line/shapes/polygon -I actions/drawing/draw/polyline -I actions/drawing/draw/text -I actions/drawing/edit -I actions/drawing/info -I actions/drawing/pick -I actions/drawing/modify -I actions/drawing/pen -I actions/drawing/rel_zero -I actions/drawing/selection -I actions/drawing/snap -I actions/drawing/zoom -I actions/file -I actions/options -I actions/print_preview -I ui -I ui/action_options -I ui/action_options/circle -I ui/action_options/curve -I ui/action_options/spline -I ui/action_options/dimensions -I ui/action_options/edit -I ui/action_options/image -I ui/action_options/info -I ui/action_options/insert -I ui/action_options/line -I ui/action_options/rect -I ui/action_options/polygon -I ui/action_options/misc -I ui/action_options/modify -I ui/action_options/ellipse -I ui/action_options/other -I ui/action_options/polyline -I ui/action_options/point -I ui/action_options/print_preview -I ui/action_options/selection -I ui/action_options/snap -I ui/action_options/text -I ui/actions -I ui/components -I ui/components/relative_position_assistant -I ui/components/comboboxes -I ui/components/containers -I ui/components/creators -I ui/components/layouts -I ui/components/pen -I ui/components/status_bar -I ui/components/toolbars -I ui/components/utils -I ui/dialogs -I ui/dialogs/actions -I ui/dialogs/actions/modify -I ui/dialogs/actions/quick_selection -I ui/dialogs/modify -I ui/dialogs/entity -I ui/dialogs/creators -I ui/dialogs/file -I ui/dialogs/file/export -I ui/dialogs/file/export/layers -I ui/dialogs/file/export/image -I ui/dialogs/file/export/makercam -I ui/dialogs/main -I ui/dialogs/settings -I ui/dialogs/settings/dimstyles -I ui/dialogs/settings/dimstyles/dimstyle_manager -I ui/dialogs/settings/dimstyles/dimstyle_manager/support -I ui/dialogs/settings/options_device -I ui/dialogs/settings/options_drawing -I ui/dialogs/settings/options_general -I ui/dialogs/settings/options_widget -I ui/dialogs/settings/shortcuts -I ui/dock_widgets -I ui/dock_widgets/block_widget -I ui/dock_widgets/command_line -I ui/dock_widgets/entity_info -I ui/dock_widgets/layer_widget -I ui/dock_widgets/layers_tree -I ui/dock_widgets/library_widget -I ui/dock_widgets/pen_palette -I ui/dock_widgets/pen_wizard -I ui/dock_widgets/property_sheet -I ui/dock_widgets/property_sheet/lib -I ui/dock_widgets/property_sheet/lib/properties -I ui/dock_widgets/property_sheet/lib/view -I ui/dock_widgets/property_sheet/lib/view/edit -I ui/dock_widgets/property_sheet/lib/widgets -I ui/dock_widgets/property_sheet/lib/widgets/sheet -I ui/dock_widgets/property_sheet/metaentity -I ui/dock_widgets/property_sheet/metaentity/entities -I ui/dock_widgets/property_sheet/metaentity/entities/document -I ui/dock_widgets/property_sheet/properties -I ui/dock_widgets/property_sheet/properties/action -I ui/dock_widgets/property_sheet/properties/bool -I ui/dock_widgets/property_sheet/properties/color -I ui/dock_widgets/property_sheet/properties/double -I ui/dock_widgets/property_sheet/properties/enum -I ui/dock_widgets/property_sheet/properties/int -I ui/dock_widgets/property_sheet/properties/layer -I ui/dock_widgets/property_sheet/properties/linetype -I ui/dock_widgets/property_sheet/properties/linewidth -I ui/dock_widgets/property_sheet/properties/rect -I ui/dock_widgets/property_sheet/properties/rsvector -I ui/dock_widgets/property_sheet/properties/string -I ui/dock_widgets/views_list -I ui/dock_widgets/ucs_list -I ui/dock_widgets/workspaces -I ui/dock_widgets/cad -I ui/main -I ui/main/init -I ui/main/persistence -I ui/main/release_check -I ui/main/support -I ui/main/fontviewer -I ui/main/workspaces -I ui/view -I main -I main/console_dxf2pdf -I test -I plugins -I ../res -I ../res/arrows -I ../res/controls -I ../res/dxf -I ../res/gdt -I ../res/icons -I ../res/images -I ../../../Qt/6.9.0/gcc_64/include -I ../../../Qt/6.9.0/gcc_64/include/QtSvg -I ../../../Qt/6.9.0/gcc_64/include/QtPrintSupport -I ../../../Qt/6.9.0/gcc_64/include/QtWidgets -I ../../../Qt/6.9.0/gcc_64/include/QtGui -I ../../../Qt/6.9.0/gcc_64/include/QtNetwork -I ../../../Qt/6.9.0/gcc_64/include/QtCore -I ../../generated/librecad/moc -I ../../generated/librecad/ui -I ../../../Qt/6.9.0/gcc_64/mkspecs/linux-g++ -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/x86_64-linux-gnu/c++/15 -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/backward -internal-isystem /usr/lib/llvm-21/lib/clang/21/include -internal-isystem /usr/local/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/15/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -std=gnu++1z -fdeprecated-macro -ferror-limit 19 -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -vectorize-loops -vectorize-slp -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/runner/work/LibreCAD/LibreCAD/out/2026-11-06-031751-4837-1 -x c++ ui/dialogs/file/export/layers/lc_exportlayersdialogservice.cpp
1/*
2 * **************************************************************************
3 * This file is part of the LibreCAD project, a 2D CAD program
4 *
5 * Copyright (C) 2025 LibreCAD.org
6 * Copyright (C) 2025 sand1024
7 *
8 * This program is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU General Public License
10 * as published by the Free Software Foundation; either version 2
11 * of the License, or (at your option) any later version.
12 *
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
21 * *********************************************************************
22 */
23#include "lc_exportlayersdialogservice.h"
24
25#include <QApplication>
26#include <QFileDialog>
27#include <QGridLayout>
28#include <QMessageBox>
29
30#include "lc_documentsstorage.h"
31#include "lc_layerexportoptions.h"
32#include "lc_layersexporter.h"
33#include "rs_graphic.h"
34#include "rs_settings.h"
35
36struct LC_FileDialogResult {
37 QString dirPath;
38 QString filePath;
39 QString fileName;
40 QString fileExtension;
41 RS2::FormatType fileType = RS2::FormatUnknown;
42};
43
44void LC_ExportLayersService::exportLayers(LC_LayersExportOptions& exportOptions, RS_Graphic* sourceGraphic) {
45 LC_ExportLayersService service;
46 service.doExportLayers(exportOptions, sourceGraphic);
1
Calling 'LC_ExportLayersService::doExportLayers'
→
47}
48
49QString LC_ExportLayersService::createExportDocumentFileName(const bool separateFileForLayer, const LC_FileDialogResult& fileInfo, const size_t exportFilesCount, const size_t currentExportLayerIndex,
50 [[maybe_unused]]const QString& exportData) {
51 QString actualFileName = QDir::toNativeSeparators(
52 fileInfo.dirPath + "/"
53 + fileInfo.fileName + (separateFileForLayer ? paddedIndex(currentExportLayerIndex + 1, exportFilesCount) : "")
54 + fileInfo.fileExtension);
55 return actualFileName;
56}
57
58void LC_ExportLayersService::doExportLayers(LC_LayersExportOptions& exportOptions, RS_Graphic* sourceGraphic) {
59 LC_FileDialogResult fileInfo;
60 exportOptions.sourceDrawingFileName = sourceGraphic->getFilename();
61 if (selectLayersExportFile(exportOptions, fileInfo)) {
2
←
Calling 'LC_ExportLayersService::selectLayersExportFile'
→
62 QApplication::setOverrideCursor(Qt::WaitCursor);
63 LC_LayersExporter layersExporter;
64 std::vector<LC_LayerExportData> exportResultList;
65 layersExporter.exportLayers(&exportOptions, sourceGraphic, exportResultList);
66 LC_DocumentsStorage storage;
67
68 const size_t exportFilesCount = exportResultList.size();
69
70 for (size_t currentExportLayerIndex = 0; currentExportLayerIndex < exportFilesCount; currentExportLayerIndex++){
71 auto& exportData = exportResultList[currentExportLayerIndex];
72 RS_Graphic* graphicToSave = exportData.graphic.get();
73 QString actualFileName = createExportDocumentFileName(exportOptions.createSeparateDocumentPerLayer,
74 fileInfo, exportFilesCount, currentExportLayerIndex, exportData.name);
75 [[maybe_unused]]bool saveWasSuccessful = storage.exportGraphics(graphicToSave, actualFileName, fileInfo.fileType);
76
77 // free each export drawing once it is saved, not after the whole loop
78 exportData.graphic.reset();
79
80 /* if (saveWasSuccessful){
81 RS_DIALOGFACTORY->commandMessage(
82 tr(R"(Saving layer "%1" as "%2" )").arg(copiedLayers, modifiedFilePath));
83 } else {
84 RS_DEBUG->print(RS_Debug::D_ERROR, "LC_ActionLayersExport::trigger: Error encountered while exporting layers");
85 return;
86 }
87*/
88 }
89 QApplication::restoreOverrideCursor();
90 }
91 exportOptions.layers.clear();
92}
93
94QString LC_ExportLayersService::paddedIndex(const int index, const int totalNumber){
95 // the maximum string size needed
96 const int fieldWidth=QString::number(totalNumber).size();
97 auto str = QString("%1").arg(index, fieldWidth, 10, QChar{'0'});
98 return str;
99}
100
101bool LC_ExportLayersService::selectLayersExportFile(LC_LayersExportOptions& options, LC_FileDialogResult& fileInfo) {
102 LC_ExportLayersService service;
103 return service.selectExportFile(options, fileInfo);
3
←
Calling 'LC_ExportLayersService::selectExportFile'
→
104}
105
106LC_ExportLayersService::LC_ExportLayersService() {}
107
108namespace
109{
110 const QStringList FILTERS_STRING_LIST = {
111 /* Drawing filters */
112 "Drawing Exchange DXF 2018 (*.dxf)",
113 "Drawing Exchange DXF 2013 (*.dxf)",
114 "Drawing Exchange DXF 2010 (*.dxf)",
115 "Drawing Exchange DXF 2007 (*.dxf)",
116 "Drawing Exchange DXF 2004 (*.dxf)",
117 "Drawing Exchange DXF 2000 (*.dxf)",
118 "Drawing Exchange DXF R14 (*.dxf)",
119 "Drawing Exchange DXF R12 (*.dxf)",
120 };
121
122 const QList<RS2::FormatType> FILTERS_TYPE_LIST =
123 {
124 /* Drawing filters */
125 RS2::FormatDXFRW2018,
126 RS2::FormatDXFRW2013,
127 RS2::FormatDXFRW2010,
128 RS2::FormatDXFRW,
129 RS2::FormatDXFRW2004,
130 RS2::FormatDXFRW2000,
131 RS2::FormatDXFRW14,
132 RS2::FormatDXFRW12,
133 };
134
135}
136
137bool LC_ExportLayersService::selectExportFile(LC_LayersExportOptions& options, LC_FileDialogResult& fileInfo) {
138 const std::pair<QString, QString> defaultDirFilter = readDefaultDirAndFilter();
139
140 auto saveFileDialog = QFileDialog(nullptr, tr("Export Layers"), defaultDirFilter.first,
141 FILTERS_STRING_LIST.join(";;"));
142 saveFileDialog.selectNameFilter(defaultDirFilter.second);
143 saveFileDialog.setAcceptMode (QFileDialog::AcceptSave);
144 saveFileDialog.setOption (QFileDialog::HideNameFilterDetails, false);
145 saveFileDialog.setOption (QFileDialog::DontUseNativeDialog, true);
146 // We do our own overwrite confirmation below; suppress the dialog's built-in
147 // one so the two do not stack into a double prompt.
148 saveFileDialog.setOption (QFileDialog::DontConfirmOverwrite, true);
149
150 const QString sourceFileName = options.sourceDrawingFileName;
151 QString preselectionFileName;
152 if (!sourceFileName.isEmpty()) {
4
←
Assuming the condition is false
→
5
←
Taking false branch
→
153 const QFileInfo sourceFileInfo(sourceFileName);
154 preselectionFileName = sourceFileInfo.baseName() + " - Export "; // fixme - sand - use options?
155 }
156 else {
157 preselectionFileName = tr("Exported Layers");
158 }
159 saveFileDialog.selectFile(preselectionFileName);
160
161 QLayout* layout = saveFileDialog.layout();
162 auto* exportOptionsWidget = new LC_LayerExportOptionsWidget(&saveFileDialog);
6
←
Memory is allocated
→
163 auto* gridLayout = dynamic_cast<QGridLayout*>(layout);
164 if (gridLayout != nullptr) {
7
←
Assuming the condition is false
→
8
←
Taking false branch
→
165 gridLayout->addWidget(exportOptionsWidget, 5, 0, 1, 3);
166 }
167
168 while (true) {
9
←
Loop condition is true. Entering loop body
→
169 if (saveFileDialog.exec() == QDialog::Accepted) {
10
←
Assuming the condition is false
→
11
←
Taking false branch
→
170 fileInfo.filePath = QDir::toNativeSeparators(QFileInfo(saveFileDialog.selectedFiles().at(0)).absoluteFilePath());
171 fileInfo.dirPath = QFileInfo(fileInfo.filePath).absolutePath();
172 fileInfo.fileName = QFileInfo(fileInfo.filePath).fileName();
173
174 const QString selectedFilter = saveFileDialog.selectedNameFilter();
175 fileInfo.fileType = getFormatType(selectedFilter);
176
177 // update file extension info
178 updateFileExtension(fileInfo, selectedFilter);
179
180 /* Confirm if the user wants to overwrite an existing file. */
181 if (QFileInfo::exists(fileInfo.filePath)) {
182 const int replaceFileResponse = QMessageBox::warning(
183 QApplication::activeWindow(),
184 tr("Export Layers"),
185 QObject::tr(R"(File "%1" already exists. Do you want to replace it?)").arg(fileInfo.fileName),
186 QMessageBox::Yes | QMessageBox::No | QMessageBox::Cancel, QMessageBox::Cancel
187 );
188
189 if (replaceFileResponse != QMessageBox::Yes) {
190 continue;
191 }
192 }
193
194 exportOptionsWidget->fillLayerExportOptions(&options);
195
196 saveDefaultDirAndFilter(fileInfo, selectedFilter);
197 return true;
198 }
199 return false;
12
←
Potential leak of memory pointed to by 'exportOptionsWidget'
200 }
201}
202
203std::pair<QString, QString> LC_ExportLayersService::readDefaultDirAndFilter() {
204 LC_GROUP_GUARDauto _guard_settings = RS_Settings::instance()->beginGroupGuard("Export.Layers");
205 {
206 QString defaultDir = LC_GET_STRRS_Settings::instance()->readStr("DirPath", QDir::toNativeSeparators(QDir::homePath()));
207 // DXF 2007 stays the default, as before the newer versions were listed.
208 QString defaultFilter = LC_GET_STRRS_Settings::instance()->readStr("FileFilter", FILTERS_STRING_LIST.at(FILTERS_TYPE_LIST.indexOf(RS2::FormatDXFRW)));
209 return {defaultDir, defaultFilter};
210 }
211}
212
213void LC_ExportLayersService::saveDefaultDirAndFilter(const LC_FileDialogResult& fileInfo, const QString& selectedFilter) {
214 LC_GROUP_GUARDauto _guard_settings = RS_Settings::instance()->beginGroupGuard("Export.Layers");
215 {
216 LC_SETRS_Settings::instance()->write("DirPath", fileInfo.dirPath);
217 LC_SETRS_Settings::instance()->write("FileFilter", selectedFilter);
218 }
219}
220
221RS2::FormatType LC_ExportLayersService::getFormatType(const QString& formatString){
222 const int index = FILTERS_STRING_LIST.indexOf(formatString);
223 return (index >= 0 && index < FILTERS_TYPE_LIST.count()) ? FILTERS_TYPE_LIST.at(index) : RS2::FormatDXFRW;
224}
225
226void LC_ExportLayersService::updateFileExtension(LC_FileDialogResult& result, const QString& selectedFilter) {
227 QString saveFileExtension = selectedFilter.mid (selectedFilter.lastIndexOf ('.'));
228 saveFileExtension.chop(1);
229 result.fileExtension = saveFileExtension;
230 if (!result.fileName.endsWith(result.fileExtension, Qt::CaseInsensitive)) {
231 result.filePath += result.fileExtension;
232 }
233 if (result.fileName.endsWith(saveFileExtension)) {
234 result.fileName.resize(result.fileName.size() - result.fileExtension.size());
235 }
236}