Bug Summary

File:librecad/src/ui/dialogs/settings/dimstyles/dimstyle_manager/support/lc_tabproxywidget.cpp
Warning:line 53, column 13
Called C++ object pointer is null

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple x86_64-pc-linux-gnu -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name lc_tabproxywidget.cpp -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=cplusplus -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 2 -fhalf-no-semantic-interposition -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fdebug-compilation-dir=/home/runner/work/LibreCAD/LibreCAD/librecad/src -fcoverage-compilation-dir=/home/runner/work/LibreCAD/LibreCAD/librecad/src -resource-dir /usr/lib/llvm-18/lib/clang/18 -D _REENTRANT -D DWGSUPPORT -D MUPARSER_STATIC -D QC_APPDIR="librecad" -D LC_VERSION=2.2.2_alpha1-607-g330d41cec -D LC_PRERELEASE=true; -D QT_NO_DEBUG -D QT_SVG_LIB -D QT_PRINTSUPPORT_LIB -D QT_WIDGETS_LIB -D QT_GUI_LIB -D QT_NETWORK_LIB -D QT_CORE_LIB -I . -I /usr/include -I ../../libraries/lciconengine -I ../../libraries/libdxfrw/src -I ../../libraries/jwwlib/src -I ../../libraries/shapelib/src -I cmd -I lib/actions -I lib/actions/visual_snap -I lib/actions/options -I lib/creation -I lib/debug -I lib/engine -I lib/engine/document -I lib/engine/document/blocks -I lib/engine/document/container -I lib/engine/document/dimstyles -I lib/engine/document/entities -I lib/engine/document/entities/support -I lib/engine/document/fonts -I lib/engine/document/io -I lib/engine/document/layers -I lib/engine/document/patterns -I lib/engine/document/selection -I lib/engine/document/textstyles -I lib/engine/document/ucs -I lib/engine/document/variables -I lib/engine/document/views -I lib/engine/clipboard -I lib/engine/overlays -I lib/engine/overlays/angles_base -I lib/engine/overlays/highlight -I lib/engine/overlays/preview -I lib/engine/overlays/references -I lib/engine/overlays/crosshair -I lib/engine/overlays/info_cursor -I lib/engine/overlays/overlay_box -I lib/engine/overlays/ucs_mark -I lib/engine/undo -I lib/engine/utils -I lib/engine/settings -I lib/fileio -I lib/filters -I lib/generators -I lib/generators/makercamsvg -I lib/generators/layers -I lib/generators/image -I lib/gui -I lib/gui/grid -I lib/gui/render -I lib/gui/render/headless -I lib/gui/render/widget -I lib/information -I lib/math -I lib/modification -I lib/selection -I lib/selection/metaentity -I lib/selection/metaentity/entities -I lib/printing -I lib/properties -I actions -I actions/dock_widgets -I actions/dock_widgets/block -I actions/dock_widgets/entity_info -I actions/dock_widgets/layer -I actions/dock_widgets/library -I actions/dock_widgets/ucs_list -I actions/drawing -I actions/drawing/draw -I actions/drawing/draw/arc -I actions/drawing/draw/circle -I actions/drawing/draw/curve -I actions/drawing/draw/spline -I actions/drawing/draw/dimensions -I actions/drawing/draw/ellipse -I actions/drawing/draw/hatch -I actions/drawing/draw/image -I actions/drawing/draw/line -I actions/drawing/draw/point -I actions/drawing/draw/rect -I actions/drawing/draw/polygon -I actions/drawing/draw/misc -I actions/drawing/draw/line/shapes -I actions/drawing/draw/line/misc -I actions/drawing/draw/line/shapes/rect -I actions/drawing/draw/line/shapes/polygon -I actions/drawing/draw/polyline -I actions/drawing/draw/text -I actions/drawing/edit -I actions/drawing/info -I actions/drawing/pick -I actions/drawing/modify -I actions/drawing/pen -I actions/drawing/rel_zero -I actions/drawing/selection -I actions/drawing/snap -I actions/drawing/zoom -I actions/file -I actions/options -I actions/print_preview -I ui -I ui/action_options -I ui/action_options/circle -I ui/action_options/curve -I ui/action_options/spline -I ui/action_options/dimensions -I ui/action_options/edit -I ui/action_options/image -I ui/action_options/info -I ui/action_options/insert -I ui/action_options/line -I ui/action_options/rect -I ui/action_options/polygon -I ui/action_options/misc -I ui/action_options/modify -I ui/action_options/ellipse -I ui/action_options/other -I ui/action_options/polyline -I ui/action_options/point -I ui/action_options/print_preview -I ui/action_options/selection -I ui/action_options/snap -I ui/action_options/text -I ui/actions -I ui/components -I ui/components/relative_position_assistant -I ui/components/comboboxes -I ui/components/containers -I ui/components/creators -I ui/components/layouts -I ui/components/pen -I ui/components/status_bar -I ui/components/toolbars -I ui/components/utils -I ui/dialogs -I ui/dialogs/actions -I ui/dialogs/actions/modify -I ui/dialogs/actions/quick_selection -I ui/dialogs/modify -I ui/dialogs/entity -I ui/dialogs/creators -I ui/dialogs/file -I ui/dialogs/file/export -I ui/dialogs/file/export/layers -I ui/dialogs/file/export/image -I ui/dialogs/file/export/makercam -I ui/dialogs/main -I ui/dialogs/settings -I ui/dialogs/settings/dimstyles -I ui/dialogs/settings/dimstyles/dimstyle_manager -I ui/dialogs/settings/dimstyles/dimstyle_manager/support -I ui/dialogs/settings/options_device -I ui/dialogs/settings/options_drawing -I ui/dialogs/settings/options_general -I ui/dialogs/settings/options_widget -I ui/dialogs/settings/shortcuts -I ui/dock_widgets -I ui/dock_widgets/block_widget -I ui/dock_widgets/command_line -I ui/dock_widgets/entity_info -I ui/dock_widgets/layer_widget -I ui/dock_widgets/layers_tree -I ui/dock_widgets/library_widget -I ui/dock_widgets/pen_palette -I ui/dock_widgets/pen_wizard -I ui/dock_widgets/property_sheet -I ui/dock_widgets/property_sheet/lib -I ui/dock_widgets/property_sheet/lib/properties -I ui/dock_widgets/property_sheet/lib/view -I ui/dock_widgets/property_sheet/lib/view/edit -I ui/dock_widgets/property_sheet/lib/widgets -I ui/dock_widgets/property_sheet/lib/widgets/sheet -I ui/dock_widgets/property_sheet/metaentity -I ui/dock_widgets/property_sheet/metaentity/entities -I ui/dock_widgets/property_sheet/metaentity/entities/document -I ui/dock_widgets/property_sheet/properties -I ui/dock_widgets/property_sheet/properties/action -I ui/dock_widgets/property_sheet/properties/bool -I ui/dock_widgets/property_sheet/properties/color -I ui/dock_widgets/property_sheet/properties/double -I ui/dock_widgets/property_sheet/properties/enum -I ui/dock_widgets/property_sheet/properties/int -I ui/dock_widgets/property_sheet/properties/layer -I ui/dock_widgets/property_sheet/properties/linetype -I ui/dock_widgets/property_sheet/properties/linewidth -I ui/dock_widgets/property_sheet/properties/rect -I ui/dock_widgets/property_sheet/properties/rsvector -I ui/dock_widgets/property_sheet/properties/string -I ui/dock_widgets/views_list -I ui/dock_widgets/ucs_list -I ui/dock_widgets/workspaces -I ui/dock_widgets/cad -I ui/main -I ui/main/init -I ui/main/persistence -I ui/main/release_check -I ui/main/support -I ui/main/fontviewer -I ui/main/workspaces -I ui/view -I main -I main/console_dxf2pdf -I test -I plugins -I ../res -I ../res/arrows -I ../res/controls -I ../res/dxf -I ../res/gdt -I ../res/icons -I ../res/images -I ../../../Qt/6.9.0/gcc_64/include -I ../../../Qt/6.9.0/gcc_64/include/QtSvg -I ../../../Qt/6.9.0/gcc_64/include/QtPrintSupport -I ../../../Qt/6.9.0/gcc_64/include/QtWidgets -I ../../../Qt/6.9.0/gcc_64/include/QtGui -I ../../../Qt/6.9.0/gcc_64/include/QtNetwork -I ../../../Qt/6.9.0/gcc_64/include/QtCore -I ../../generated/librecad/moc -I ../../generated/librecad/ui -I ../../../Qt/6.9.0/gcc_64/mkspecs/linux-g++ -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14 -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/x86_64-linux-gnu/c++/14 -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/backward -internal-isystem /usr/lib/llvm-18/lib/clang/18/include -internal-isystem /usr/local/include -internal-isystem /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O2 -std=gnu++1z -fdeprecated-macro -ferror-limit 19 -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -vectorize-loops -vectorize-slp -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/runner/work/LibreCAD/LibreCAD/out/2026-08-04-154929-5069-1 -x c++ ui/dialogs/settings/dimstyles/dimstyle_manager/support/lc_tabproxywidget.cpp
1/*
2 * ********************************************************************************
3 * This file is part of the LibreCAD project, a 2D CAD program
4 *
5 * Copyright (C) 2025 LibreCAD.org
6 * Copyright (C) 2025 sand1024
7 *
8 * This program is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU General Public License
10 * as published by the Free Software Foundation; either version 2
11 * of the License, or (at your option) any later version.
12 *
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
21 * ********************************************************************************
22 */
23
24#include "lc_tabproxywidget.h"
25
26
27#include <QApplication>
28#include <QLabel>
29#include <QSet>
30#include <QStackedLayout>
31#include <QWidget>
32
33LC_TabProxyWidget::LC_TabProxyWidget() {
34}
35
36static QHash<QWidget*, QSet<LC_TabProxyWidget*>> g_targetWidgetToProxies;
37
38void LC_TabProxyWidget::setTargetWidget(QWidget* targetWidget) {
39 if (targetWidget != m_targetWidget) {
1
Assuming 'targetWidget' is not equal to field 'm_targetWidget'
→
2
←
Taking true branch
→
40 if (m_targetWidget != nullptr) {
3
←
Assuming the condition is true
→
4
←
Taking true branch
→
41 m_targetWidget->removeEventFilter(this);
42
43 QSet<LC_TabProxyWidget*>* proxiesForTargetWidget = g_targetWidgetToProxies.contains(m_targetWidget)
5
←
Assuming the condition is false
→
6
←
'?' condition is false
→
7
←
'proxiesForTargetWidget' initialized to a null pointer value
→
44 ? &g_targetWidgetToProxies[m_targetWidget]
45 : nullptr;
46 if ((proxiesForTargetWidget == nullptr) || (proxiesForTargetWidget->isEmpty())) {
47 // fixme - sand - well, that's ugly enought... yet if we are here - this a severe developer's bug, so let it be for now...
48 printf("LC_TabProxyWidget::setTargetWidget(NULL): can't proxies-table for target widget %p is %s!\n", targetWidget,
49 (proxiesForTargetWidget != nullptr) ? "empty" : "missing");
8
←
'?' condition is false
→
50 }
51 Q_ASSERT(proxiesForTargetWidget != nullptr && !proxiesForTargetWidget->isEmpty())static_cast<void>(false && (proxiesForTargetWidget
!= nullptr && !proxiesForTargetWidget->isEmpty())
);
52
53 proxiesForTargetWidget->remove(this);
9
←
Called C++ object pointer is null
54 if (proxiesForTargetWidget->isEmpty()) {
55 g_targetWidgetToProxies.remove(m_targetWidget);
56 delete m_targetWidget;
57 }
58 else if (dynamic_cast<LC_TabProxyWidget*>(m_targetWidget->parentWidget()) == this) {
59 proxiesForTargetWidget->values().at(0)->adoptTargetWidget();
60 // hand him off to another proxy to for safekeeping
61 }
62 }
63
64 m_targetWidget = targetWidget;
65
66 if (m_targetWidget != nullptr) {
67 if (!g_targetWidgetToProxies.contains(m_targetWidget)) {
68 g_targetWidgetToProxies[m_targetWidget] = QSet<LC_TabProxyWidget*>();
69 }
70 g_targetWidgetToProxies[m_targetWidget].insert(this);
71
72 if ((!isHidden()) || (m_targetWidget->parentWidget() == nullptr)
73 || (dynamic_cast<LC_TabProxyWidget*>(m_targetWidget->parentWidget()) == nullptr)) {
74 adoptTargetWidget();
75 }
76
77 updateSizeConstraints();
78 m_targetWidget->installEventFilter(this);
79 }
80 }
81}
82
83bool LC_TabProxyWidget::eventFilter(QObject* o, QEvent* e) {
84 if (o == m_targetWidget) {
85 if (e->type() == QEvent::Resize) {
86 updateSizeConstraints();
87 }
88 /*if (e->type() == QEvent::MouseMove) {
89 // LC_ERR << "Mouse MOve";
90 }
91 if (e->type() == QEvent::NativeGesture) {
92 // LC_ERR << "Native Guesture";
93 }
94 if (e->type() == QEvent::Wheel) {
95 // LC_ERR << "Wheel";
96 }
97 else {
98 // LC_ERR << e->type();
99 }*/
100 }
101 return QWidget::eventFilter(o, e);
102}
103
104void LC_TabProxyWidget::updateSizeConstraints() {
105 if (m_targetWidget != nullptr) {
106 setMinimumSize(m_targetWidget->minimumSize());
107 setMaximumSize(m_targetWidget->maximumSize());
108 setSizePolicy(m_targetWidget->sizePolicy());
109 }
110 else {
111 setMinimumSize(QSize(0, 0));
112 setMaximumSize(QSize(QWIDGETSIZE_MAX((1<<24)-1), QWIDGETSIZE_MAX((1<<24)-1)));
113 setSizePolicy(QSizePolicy(QSizePolicy::Ignored, QSizePolicy::Ignored));
114 }
115}
116
117void LC_TabProxyWidget::showEvent(QShowEvent* e) {
118 adoptTargetWidget();
119 QWidget::showEvent(e);
120 if (m_targetWidget != nullptr) {
121 m_targetWidget->show();
122 }
123}
124
125void LC_TabProxyWidget::adoptTargetWidget() {
126 if (((m_targetWidget) != nullptr) && (m_targetWidget->parentWidget() != this)) {
127 QLayout* layout = m_targetWidget->layout();
128 if (layout != nullptr) {
129 layout->removeWidget(m_targetWidget);
130 }
131
132 m_targetWidget->setParent(this);
133 m_layout->addWidget(m_targetWidget);
134 }
135}
136
137static void setWidgetBackgroundColor(QWidget* w, const QColor bc) {
138 QPalette p = w->palette();
139 p.setColor(QPalette::Window, bc);
140 w->setAutoFillBackground(true);
141 w->setPalette(p);
142}